fix(eso): remove external secrets key collisions #212
Conversation
Signed-off-by: Antonia Gaete <agaete@linuxfoundation.org>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughRemoved the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Comment |
agaetep
changed the title
There was a problem hiding this comment.
Pull request overview
This PR removes the workaround configuration for Auth0 external secrets key collisions from the Helm chart values. With the passwordless client renamed and support for the service-pcc: enabled tag now available, the configuration can be managed through Tofu/Terraform instead of being hard-coded in the chart's values.yaml file.
- Removes the
dataFromsection containing Auth0 client secret extraction and rewriting rules - Eliminates hard-coded references to
LFX_ONEandLFX_ONE_PasswordlessAuth0 clients - Removes the service: "pcc" tag-based secret finder with conflict policy
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Antonia Gaete <82597086+agaetep@users.noreply.github.com>
Now that we have support for the tags
service-pcc: enabledand the passwordless client was renamed, we no longer need the chart to be fixed here. This PR removes that and allows tofu to be the chart's source of truth until the shared helm chart handles it.